Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SpaceID domain #93

Merged
merged 4 commits into from Mar 23, 2023
Merged

add SpaceID domain #93

merged 4 commits into from Mar 23, 2023

Conversation

ZhongFuze
Copy link
Contributor

add SpaceID domain
issue #92

nykma
nykma requested changes Mar 23, 2023
View reviewed changes
Copy link
Member

@nykma nykma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough

src/upstream/space_id/mod.rs Outdated Show resolved Hide resolved
@ZhongFuze ZhongFuze requested a review from nykma March 23, 2023 07:24
nykma
nykma approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@nykma nykma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🉑

@nykma nykma merged commit fa159d9 into develop Mar 23, 2023
@nykma nykma deleted the upstream/space-id branch March 23, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nykma nykma nykma approved these changes

@fengshanshan fengshanshan Awaiting requested review from fengshanshan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZhongFuze @nykma