Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CVPixelBufferPoolCreatePixelBuffer result comparison crash #32

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Fix CVPixelBufferPoolCreatePixelBuffer result comparison crash #32

merged 1 commit into from
Sep 17, 2020

Conversation

russ-stamant
Copy link

@russ-stamant russ-stamant commented Sep 17, 2020

Hello.

I fixed the issue I found with the NextLevelSessionExporter when building the framework with Xcode 12.

Using switch with it's default case with let result = CVPixelBufferPoolCreatePixelBuffer causing this exception when running app and using the exporter

** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: '*** -[AVAssetWriterInput appendSampleBuffer:] Cannot append sample buffer: Must start a session (using -[AVAssetWriter startSessionAtSourceTime:) first'

I also changed switch result to if result == kCVReturnSuccess since we have nothing left to execute in default case.

…auses a runtime crash when building w/ Xcode 12
@piemonte piemonte merged commit 218de95 into NextLevel:master Sep 17, 2020
@piemonte
Copy link
Contributor

thanks @rshevchuk much appreciated ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants