Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nd-common): Repoint parent charts back to published chart repo #294

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(nd-common): Repoint parent charts back to published chart repo #294

wants to merge 1 commit into from

Conversation

LaikaN57
Copy link
Member

No description provided.

@LaikaN57 LaikaN57 requested a review from a team as a code owner April 18, 2024 19:44
@LaikaN57 LaikaN57 requested a review from scohen-nd April 18, 2024 19:45
@LaikaN57 LaikaN57 self-assigned this Apr 18, 2024
@LaikaN57 LaikaN57 added bug Something isn't working good first issue Good for newcomers dependencies Pull requests that update a dependency file labels Apr 18, 2024
diranged
diranged approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@diranged diranged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good - could we add a followup to add renovatebot here so that it will self-update these charts for us? (in a different PR)

@github-actions github-actions bot deleted the adk-fix-nd-common-repo branch June 19, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diranged diranged diranged approved these changes

@scohen-nd scohen-nd Awaiting requested review from scohen-nd

@corydolphin corydolphin Awaiting requested review from corydolphin

Assignees

@LaikaN57 LaikaN57

Labels
bug Something isn't working dependencies Pull requests that update a dependency file good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LaikaN57 @diranged