온보딩 에러 처리 보완 및 화면 테블릿 대응 #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
easyhooon
commented
Dec 27, 2023
easyhooon
commented
- 로그인 토큰을 정상적으로 발급받지 못할 경우 온보딩 화면에도 진입하지 못하도록 설정(네트워크 에러 다이얼로그 호출)
- 온보딩을 완료해야지만 홈화면으로 이동할 수 있도록 온보딩 완료 여부 확인 로직 추가
- 온보딩 화면 태블릿 대응
| 이전 1 | 이전 2 |
|---|---|
 |
 |
| 이후 1 | 이후 2 |
|---|---|
 |
 |
로그인을 하지 않았고, 로그인 토큰이 정상적으로 생성되었을 경우에만 온보딩 화면으로 이동하도록 로직 보완
테블릿에서 글씨가 연한 회색으로 보이는 이슈 해결
TODO 버튼이 horizontal pager 위에 올라오는 문제를 해결해야함
온보딩을 완료하지 않아도 온보딩이 완료되어 홈 화면으로 넘어가게 되는 문제 해결
easyhooon
added
hotfix
likppi10
approved these changes
Dec 27, 2023
| @@ -149,8 +156,7 @@ internal fun OnBoardingScreen( | |||
| ) { | |||
| Box( | |||
| modifier = Modifier | |||
| .fillMaxWidth() | |||
| .aspectRatio(1f) | |||
| .aspectRatioBasedOnOrientation(1f) | |||
There was a problem hiding this comment.
이거 때문에 태블릿에서 못 생기게 나온거구나
There was a problem hiding this comment.
가로모드일때는 세로에 맞춰서, 세로모드일때는 가로에 맞춰서(더 짧은 길이) 1:1 비율로 설정하는 modifier 야
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.