-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
04-functions/headers.mdx #172
Conversation
|
||
### Examples | ||
- [`Headers.has()`](https://developer.mozilla.org/en-US/docs/Web/API/Headers/has): `Headers` 객체가 특정 헤더를 포함하고 있는지를 나타내는 boolean 값을 반환합니다. | ||
- [`Headers.keys()`](https://developer.mozilla.org/en-US/docs/Web/API/Headers/keys): 해당 객체에 포함된 key/value 쌍의 key를 순회하여 확인할 수 있는 [`이터레이터`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Iteration_protocols)를 반환합니다. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this object
를 이 객체
로 표현하면 어색할 거 같아서 해당 객체
로 표현했는데 의견 부탁드립니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
모두 Headers
객체의 method에 대한 설명이니 "해당 객체"를 "Headers
객체"로 표현해도 좋을 것 같습니다.
억양에 대한 가이드라인의 두 번째 항목과 비슷하게 주어를 반복하는 것이 명확하다 생각합니다.
다른 분들의 의견도 궁금합니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
일단 말씀 주신 부분에 대해서 수정했습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 '이', '해당'의 경우 앞에 언급된 명사 그대로 가져오는 것이 좋다는 것에 동의합니다!
title: headers | ||
description: API reference for the headers function. | ||
title : headers | ||
descriptoion : headers function에 대한 API 레퍼런스입니다. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description에 대한 오타가 있습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오타 수정했습니다! 확인 감사합니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다! 리뷰 반영 부탁드립니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
수고하셨습니다! 추가로 하시고 싶은 티켓이 있다면 신청해주셔도 됩니다!
추가적으로 다른분들 리뷰도 열심히 해주셔서 혹시 관심있으시다면 같이 메인테이너 작업 가능하실까용?
기여자용
문서 개선
pnpm prettier-fix
를 실행하여 서식 문제를 해결합니다. - 문서 기여 가이드를 읽고 문서 지침을 따르는지 확인하세요: https://github.com/Nextjs-kr/Nextjs.ko/blob/main/packages/next/README.mdProgress
pnpm prettier-fix