Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

01-installation.mdx 번역 #179

Merged
merged 14 commits into from Jun 25, 2023
Merged

01-installation.mdx 번역 #179

merged 14 commits into from Jun 25, 2023

Conversation

sumi-0011
Copy link
Contributor

@sumi-0011 sumi-0011 commented Jun 22, 2023

기여자용

close #4

문서 개선

Progress


```bash filename="Terminal"
npm install next@latest react@latest react-dom@latest
```

Open `package.json` and add the following `scripts`:
`package.json`을 열고, 아래와 같은 `script`를 추가합니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

script 👉 scripts
s 누락된 것 같습니다!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니다!

Co-authored-by: JiHee Han <57996351+g2hhh2ee@users.noreply.github.com>
Comment on lines -84 to +86
Create a [root layout](/docs/app/building-your-application/routing/pages-and-layouts#root-layout-required) inside `app/layout.tsx` with the required `<html>` and `<body>` tags:
필수적으로 `<html>`와 `<body>` 태그를 사용하여 `app/layout.tsx` 내에 [root layout](/docs/app/building-your-application/routing/pages-and-layouts#root-layout-required)을 생성합니다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Create a [root layout](/docs/app/building-your-application/routing/pages-and-layouts#root-layout-required) inside `app/layout.tsx` with the required `<html>` and `<body>` tags:
필수적으로 `<html>``<body>` 태그를 사용하여 `app/layout.tsx` 내에 [root layout](/docs/app/building-your-application/routing/pages-and-layouts#root-layout-required)을 생성합니다.
필수적으로 `<html>``<body>` 태그를 사용하여 `app/layout.tsx` 내에 [root layout](/docs/app/building-your-application/routing/pages-and-layouts#root-layout-required)을 생성합니다:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모범 사례를 봤을 때 쌍점은 거의 사용하지 않습니다.가 있으므로 적용하지 않겠습니다!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그렇네요! 덕분에 저도 다시 한 번 확인했습니다 😊

sumi-0011 and others added 2 commits June 23, 2023 02:12
Co-authored-by: 이채준 - CJ Lee <chaejunlee@knu.ac.kr>
Co-authored-by: 이채준 - CJ Lee <chaejunlee@knu.ac.kr>
@sumi-0011
Copy link
Contributor Author

리뷰 반영했습니다!

Co-authored-by: 이채준 - CJ Lee <chaejunlee@knu.ac.kr>
Co-authored-by: 이채준 - CJ Lee <chaejunlee@knu.ac.kr>
Co-authored-by: 이채준 - CJ Lee <chaejunlee@knu.ac.kr>
Co-authored-by: 이채준 - CJ Lee <chaejunlee@knu.ac.kr>
@chaejunlee
Copy link
Contributor

빠르게 리뷰 확인해주시고 반영해주셔서 감사합니다!

@@ -121,14 +123,14 @@ export default function Page() {
}
```

> **Good to know**: If you forget to create `layout.tsx`, Next.js will automatically create this file for you when running the development server with `next dev`.
> **참고**: `layout.tsx`를 생성하는 것을 잊어버린 경우, `next dev` 명령어로 개발 서버를 실행할 때 Next.js가 이 파일을 자동으로 생성합니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nextjs.kr 리드미 내용을 보면
Good to know알아두면 좋은 정보로 표기하고있는것같은데 무엇으로 번역해야할지 약간 혼란스럽네요 🤔

저도 동일한 부분(Good to know)을 수정하는중이라 어느것으로 수정하면 좋을지 다른분들의 의견이 듣고싶어요!!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-06-23 at 2 33 20

윤창현님께서 "참고"라고 작성하신 것을 보았는데 지금 보니 "참고"로 작성하라고 하신 것 보다 "참고해라"라고 하신 말씀이신 것 같기도 하네요.. 🤔

아 Good to know는 메모 처리하는 말씀이셨네요. 혼란을 드려 죄송합니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@

Screenshot 2023-06-23 at 2 33 20 윤창현님께서 "참고"라고 [작성하신 것](https://github.com//pull/140#discussion_r1237122900)을 보았는데 지금 보니 "참고"로 작성하라고 하신 것 보다 "참고해라"라고 하신 말씀이신 것 같기도 하네요.. 🤔

아 Good to know는 메모 처리하는 말씀이셨네요. 혼란을 드려 죄송합니다.

음 그런 알아두면 좋은 정보로 표기하면 될까요?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

참고로 해주세요!

Copy link
Member

@ChanghyeonYoon ChanghyeonYoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 리뷰 반영 부탁드립니다!


> **Good to know**: While you can use the [Pages Router](/docs/pages) in your new project. We recommend starting new applications with the App Router to leverage React's latest features.
> **Good to know**: 새 프로젝트에서 [Pages Router](/docs/pages)를 사용할 수 있지만, React의 최신 기능을 활용하려면 App Router로 새로운 애플리케이션을 시작하는 것이 좋습니다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

가이드에 따라 Good to know -> 참고로 변경 부탁드립니다!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

가이드에 따라 Good to know -> 참고로 변경 부탁드립니다!

수정했습니다!

@@ -121,14 +123,14 @@ export default function Page() {
}
```

> **Good to know**: If you forget to create `layout.tsx`, Next.js will automatically create this file for you when running the development server with `next dev`.
> **참고**: `layout.tsx`를 생성하는 것을 잊어버린 경우, `next dev` 명령어로 개발 서버를 실행할 때 Next.js가 이 파일을 자동으로 생성합니다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

참고로 해주세요!

Copy link
Member

@ChanghyeonYoon ChanghyeonYoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
수고하셨습니다! 추가로 하시고 싶은 티켓이 있다면 신청해주셔도 됩니다!

@ChanghyeonYoon ChanghyeonYoon merged commit b3e3a11 into Nextjs-kr:main Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 문서 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

01-installation.mdx
6 participants