Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

02-app > 02-api-reference > 04-functions > next-request.mdx #270

Merged
merged 3 commits into from
Jun 30, 2023

Conversation

KirschX
Copy link
Contributor

@KirschX KirschX commented Jun 26, 2023

기여자용

문서 개선

Progress

Copy link
Contributor

@chaejunlee chaejunlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 원문에 없는 볼드체를 다시 한 번 확인해주시고 제거해주세요!

request.cookies.getAll()
```

### `delete(name)`

Given a cookie name, delete the cookie from the request.
쿠키 **이름**이 주어질 때 request에서 쿠키를 지웁니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
쿠키 **이름**이 주어질 때 request에서 쿠키를 지웁니다.
쿠키 이름이 주어지면 request에서 쿠키를 지웁니다.

현재 페이지에 존재하는 "~할 때"는 "~하면"으로 수정되면 좋을 것 같습니다! 원문에 없는 볼드체는 삭제하겠습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영했습니다, 리뷰 감사합니다ㅎㅎ

// request will have a `Set-Cookie:show-banner=false;path=/home` header
// /home이라는 수신 request가 주어질 때
// 배너를 숨기도록 쿠키를 설정
// request에는 `Set-Cookie:show-banner=false;path=/home` 헤더가 존재
request.cookies.set('show-banner', 'false')
```

### `get(name)`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### `get(name)`
### `get(이름)`

함수의 매개변수는 한글로 설정하는 건 어떨까요? #158 에서와 같이 수정해주셨으면 좋겠습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니다!

request.cookies.delete('experiments')
```

### `has(name)`

Given a cookie name, return `true` if the cookie exists on the request.
쿠키 **이름**이 주어질 때 request에 쿠키가 존재한다면 true를 반환.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
쿠키 **이름** 주어질 때 request에 쿠키가 존재한다면 true를 반환.
쿠키 이름이 주어질 때 request에 쿠키가 존재한다면 `true` 반환.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런 실수를!! 감사합니다.

request.cookies.has('experiments')
```

### `clear()`

Remove the `Set-Cookie` header from the request.
리퀘스트에서 'Set-Cookie' 헤더를 제거.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
리퀘스트에서 'Set-Cookie' 헤더를 제거.
리퀘스트에서 `Set-Cookie` 헤더를 제거.

@chaejunlee chaejunlee self-requested a review June 30, 2023 08:11
Copy link
Contributor

@chaejunlee chaejunlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 머지해도 좋을 것 같습니다. 다른 남은 티켓 진행 원하시면 댓글 남겨주세요!

@chaejunlee chaejunlee merged commit 6b08eb9 into Nextjs-kr:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 문서 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants