Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

03-pages->01-building-your-application->01-routing->02-dynamic-routes.mdx #378

Merged
merged 2 commits into from
Aug 9, 2023
Merged

03-pages->01-building-your-application->01-routing->02-dynamic-routes.mdx #378

merged 2 commits into from
Aug 9, 2023

Conversation

Collection50
Copy link
Contributor

@Collection50 Collection50 commented Jul 1, 2023 •
edited
Loading

기여자용

문서 개선

Progress

close #48

@Collection50 Collection50 changed the title docs: dynamic-routes 번역 초안 작성 03-pages->01-building-your-application->01-routing->02-dynamic-routes.mdx Jul 1, 2023
@ChanghyeonYoon ChanghyeonYoon added the documentation 문서 작업 label Jul 1, 2023
@haileyport haileyport mentioned this pull request Jul 2, 2023
Open
@sunmerrr sunmerrr requested review from sunmerrr and removed request for ChanghyeonYoon July 21, 2023 00:57
@sunmerrr
Copy link
Contributor

@Collection50 수고하셨습니다!! 리뷰 확인부탁드려요:)

@Collection50
Copy link
Contributor Author

@Collection50 수고하셨습니다!! 리뷰 확인부탁드려요:)

모든 수정사항 반영했습니다.

yoo-jimin127
yoo-jimin127 approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@yoo-jimin127 yoo-jimin127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 수고 많으셨습니다 ☺️👍
추가로 번역 희망하시는 챕터의 경우 이슈에 작성해주셔도 됩니다!

@yoo-jimin127 yoo-jimin127 merged commit 301950a into Nextjs-kr:main Aug 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunmerrr sunmerrr sunmerrr approved these changes

@yoo-jimin127 yoo-jimin127 yoo-jimin127 approved these changes

Assignees

@Collection50 Collection50

Labels
documentation 문서 작업 In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

02-dynamic-routes.mdx
4 participants
@Collection50 @sunmerrr @yoo-jimin127 @ChanghyeonYoon