Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 03-pages > 02-api-reference > 03-next-config-js > env.mdx (수정) #418

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

ssseok
Copy link
Contributor

@ssseok ssseok commented Jul 11, 2023

기여자용

문서 개선

Progress

@ssseok ssseok changed the title docs: 03-pages > 02-api-reference > 03-next-config-js > env.mdx docs: 03-pages > 02-api-reference > 03-next-config-js > env.mdx (수정) Jul 11, 2023
@ssseok
Copy link
Contributor Author

ssseok commented Jul 11, 2023

피드백 부탁드립니다.

@haileyport haileyport linked an issue Jul 12, 2023 that may be closed by this pull request
Comment on lines +2 to +3
title: 환경 변수
description: 빌드 시 Next.js 애플리케이션에서 환경 변수를 추가하고 액세스하는 방법을 알아보세요.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 문서는 위 부분만 번역하시면 됩니다! 위 부분만 번역한 걸로 수정해주실 수 있을까요?

Copy link
Contributor Author

@ssseok ssseok Jul 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정하겠습니다

@ssseok
Copy link
Contributor Author

ssseok commented Jul 15, 2023

@chaejunlee 수정하였습니다!

Copy link
Contributor

@chaejunlee chaejunlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

간단한 페이지인데 수정 사항이 많네요,, ㅎㅎ 마지막으로 수정 부탁 드립니다.

@@ -2,48 +2,3 @@
title: 환경 변수
description: 빌드 시 Next.js 애플리케이션에서 환경 변수를 추가하고 액세스하는 방법을 알아보세요.
---
Copy link
Contributor

@chaejunlee chaejunlee Jul 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
---
source: app/api-reference/next-config-js/env
---

source 부분 추가해주세요! pages 문서는 app 문서 내용을 바라보기 때문에 source 빼먹으시면 안 됩니다.

@@ -2,48 +2,3 @@
title: 환경 변수
description: 빌드 시 Next.js 애플리케이션에서 환경 변수를 추가하고 액세스하는 방법을 알아보세요.
---

Copy link
Contributor

@chaejunlee chaejunlee Jul 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{/* DO NOT EDIT. The content of this doc is generated from the source above. To edit the content of this page, navigate to the source page in your editor. You can use the `<PagesOnly>Content</PageOnly>` component to add content that is specific to the Pages Router. Any shared content should not be wrapped in a component. */}

아래 내용 추가해주세요! 주석 부분도 지우시면 안 됩니다.

@ssseok
Copy link
Contributor Author

ssseok commented Jul 16, 2023

@chaejunlee 수정하였습니다. 전에 app안의 있는 env로 잘못 수정하여서 그대로인줄 알았습니다.😢

@chaejunlee chaejunlee self-requested a review July 24, 2023 14:44
Copy link
Contributor

@chaejunlee chaejunlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 기여해주셔서 감사합니다!!

@chaejunlee chaejunlee merged commit 08bc855 into Nextjs-kr:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

env.mdx
2 participants