Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

03-pages > 01-building-your-application > 06-configuring > 14-preview-mode.mdx #429

Merged
merged 19 commits into from
Sep 11, 2023

Conversation

harutea
Copy link
Contributor

@harutea harutea commented Aug 11, 2023

기여자용

문서 개선

Progress

@harutea
Copy link
Contributor Author

harutea commented Aug 11, 2023

리뷰 부탁드립니다!
첫 오픈 소스 기여라 미숙한 부분이 많습니다.

덧붙여 #308 이슈에도 적어놓았습니다만,
번역 신청 이후 Github username을 변경(teacrepe -> harutea)하게 되었습니다.
혼란을 드려 죄송합니다!

@marvelopers marvelopers requested review from marvelopers and removed request for ChanghyeonYoon August 18, 2023 09:29
@ChanghyeonYoon
Copy link
Contributor

@harutea 리뷰 이후 작업이 몇일 동안 이뤄지지 않아 9월 13일까지 작업이 없을 경우 이슈를 close하고 새로운 분에게 할당하겠습니다!

@harutea
Copy link
Contributor Author

harutea commented Sep 6, 2023

@ChanghyeonYoon PR 이후 리뷰를 기다리고 있습니다! 혹시 제가 놓치고 있는 부분이 있는 건가요?

@ChanghyeonYoon
Copy link
Contributor

@harutea 제가 착오가 있었네요 ㅠㅠ 바로 리뷰 진행될 수 있도록 하겠습니다!

@harutea
Copy link
Contributor Author

harutea commented Sep 6, 2023

@ChanghyeonYoon 아하, 넵 알겠습니다!

Copy link
Contributor

@marvelopers marvelopers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harutea
리뷰가 늦어져서 죄송합니다. 번역하느라 고생하셨습니다. 코멘트 확인 후 반영해주세요 :)
전체적으로 more on this later이에 대한 자세한 내용은 나중에 설명하겠습니다로 변경해주세요.

harutea and others added 9 commits September 9, 2023 03:03
…review-mode.mdx

Co-authored-by: �chloe.dev(클로이) <briller015@gmail.com>
…review-mode.mdx

Co-authored-by: �chloe.dev(클로이) <briller015@gmail.com>
…review-mode.mdx

Co-authored-by: �chloe.dev(클로이) <briller015@gmail.com>
…review-mode.mdx

Co-authored-by: �chloe.dev(클로이) <briller015@gmail.com>
…review-mode.mdx

Co-authored-by: �chloe.dev(클로이) <briller015@gmail.com>
…review-mode.mdx

Co-authored-by: �chloe.dev(클로이) <briller015@gmail.com>
…review-mode.mdx

Co-authored-by: �chloe.dev(클로이) <briller015@gmail.com>
@harutea
Copy link
Contributor Author

harutea commented Sep 8, 2023

@marvelopers 감사합니다. 리뷰 내용 반영했습니다!

Copy link
Contributor

@yoo-jimin127 yoo-jimin127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 기여해주셔서 감사합니다 :) 👍
추가적으로 번역 희망하시는 챕터의 경우 이슈에 작성해주세요!!

@yoo-jimin127 yoo-jimin127 merged commit 8bf95a2 into Nextjs-kr:main Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants