Detect incompatible file systems #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…consideration. If it's incompatible we show an error and block the user from selecting that game.
This was referenced May 24, 2018
squid-box
added a commit
to squid-box/Nexus-Mod-Manager
that referenced
this pull request
May 27, 2018
…ot be shown when scanning for games.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended as a "fix" for #19 and #131 , which will block the user from enabling a game in NMM if it's installed on an unsupported file system.
During game discovery NMM will now determine what file system the drive the game is installed on has, and check against a defined list of incompatible systems. If an incompatible file system is detected, the following message will be shown and the user will not be able to enable that game mode:
The file systems currently deemed unfit (based on #19 and #131) are:
Arguably you could allow the user some other option, like selecting another path - but it seems unlikely that a user has the same game installed on two different drives at the same time.