Entity/Core: Vitals, Spell Costing, Dash implementation #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirmmin
added a commit
to kirmmin/NexusForever
that referenced
this pull request
Oct 11, 2020
Fabi
reviewed
Oct 11, 2020
Source/NexusForever.WorldServer/Game/Spell/GlobalSpellManager.cs
Outdated
Show resolved
Hide resolved
Fabi
reviewed
Oct 11, 2020
Fabi
reviewed
Oct 11, 2020
MaxtorCoder
reviewed
Oct 11, 2020
Fabi
reviewed
Oct 11, 2020
kirmmin
force-pushed
the
effects-vitals
branch
2 times, most recently
from
7387c99
to
242d4d9
Compare
Rawaho
reviewed
Oct 14, 2020
kirmmin
force-pushed
the
effects-vitals
branch
from
242d4d9
to
9740d47
Compare
Converted Vital handlers to attribute cache Removed unused method Refactored Delegates to EntityManager Innate Requirement check work Innate cost requirement support Added interrupt armor Dash support Regeneration update & timer Unit & Player Events refactor Tidy following PR review Tidied up Dash Stat check Removed Dash spells from AssetManager Removed HandleDash method in Player Updated MessageHandler to handle dash instead Implemented Spell Lookup Manager
|
Refactored slightly to include the start of a Spell Lookup Manager. I don't suspect we'd use this for much else as the vast majority of spells are triggered from procs, which I really need to look into implementing - but that's a deep hole that I am not interested in looking into yet. This is ready for review, @Rawaho :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #307, #308
Adds a few features on top of Vitals mapping:
SpellEffectsupport