Fix: UnAssigned naming

NexusMutual · Jan 5, 2023 · c44ca29 · c44ca29
1 parent 3302f30
commit c44ca29
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/contracts/mocks/MasterMock.sol b/contracts/mocks/MasterMock.sol
@@ -9,7 +9,7 @@ import "../modules/capital/Pool.sol";
 contract MasterMock {
 
   enum Role {
-    NonMember,
+    UnAssigned,
     AdvisoryBord,
     Member,
     Owner

diff --git a/lib/constants.js b/lib/constants.js
@@ -32,7 +32,7 @@ const NXMasterOwnerParamType = {
 };
 
 const Role = {
-  NonMember: 0,
+  UnAssigned: 0,
   AdvisoryBoard: 1,
   Member: 2,
   Owner: 3,

diff --git a/test/unit/MemberRoles/stateManagement.js b/test/unit/MemberRoles/stateManagement.js
@@ -84,25 +84,25 @@ describe('state management', function () {
       advisoryBoardMembers: [advisoryBoardMember],
     } = this.accounts;
 
-    // checkRole automatically returns true when the target role is NonMember/UnAssigned
+    // checkRole automatically returns true when the target role is UnAssigned
     const isMemberMember = await memberRoles.checkRole(member.address, Role.Member);
-    const isMemberNonMember = await memberRoles.checkRole(member.address, Role.NonMember);
+    const isMemberNonMember = await memberRoles.checkRole(member.address, Role.UnAssigned);
     const isMemberABMember = await memberRoles.checkRole(member.address, Role.AdvisoryBoard);
 
     expect(isMemberMember).to.be.equal(true);
     expect(isMemberNonMember).to.be.equal(true);
     expect(isMemberABMember).to.be.equal(false);
 
     const isNonMemberMember = await memberRoles.checkRole(nonMember.address, Role.Member);
-    const isNonMemberNonMember = await memberRoles.checkRole(nonMember.address, Role.NonMember);
+    const isNonMemberNonMember = await memberRoles.checkRole(nonMember.address, Role.UnAssigned);
     const isNonMemberABMember = await memberRoles.checkRole(nonMember.address, Role.AdvisoryBoard);
 
     expect(isNonMemberMember).to.be.equal(false);
     expect(isNonMemberNonMember).to.be.equal(true);
     expect(isNonMemberABMember).to.be.equal(false);
 
     const isABMemberMember = await memberRoles.checkRole(advisoryBoardMember.address, Role.Member);
-    const isABMemberNonMember = await memberRoles.checkRole(advisoryBoardMember.address, Role.NonMember);
+    const isABMemberNonMember = await memberRoles.checkRole(advisoryBoardMember.address, Role.UnAssigned);
     const isABMemberABMember = await memberRoles.checkRole(advisoryBoardMember.address, Role.AdvisoryBoard);
 
     expect(isABMemberMember).to.be.equal(true);