Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: Cover Products #1046

Open
wants to merge 112 commits into
base: release-candidate
Choose a base branch
from
Open

release: Cover Products #1046

wants to merge 112 commits into from

Conversation

MilGard91
Copy link
Contributor

Context

Include relevant motivation and context. A link to the issue is enough if it contains all the relevant
information.

Changes proposed in this pull request

Include a summary of the change.

Test plan

Please describe the tests cases that you ran to verify your changes. Add further instructions on
how to run them if needed (i.e. migration / deployment scripts, env vars, etc).

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@MilGard91 MilGard91 force-pushed the feature/cover-products-contract-rebased branch from 4af53cf to c578f87 Compare December 14, 2023 08:18
@roxdanila roxdanila linked an issue Jan 10, 2024 that may be closed by this pull request
Reduce size of the Cover.sol contract #885
Open
@roxdanila roxdanila force-pushed the feature/cover-products-contract-rebased branch from 2dbd71c to e12123f Compare January 10, 2024 10:40
@roxdanila roxdanila marked this pull request as ready for review January 10, 2024 10:41
@MilGard91 MilGard91 force-pushed the feature/cover-products-contract-rebased branch from e12123f to 96a0ffc Compare March 14, 2024 07:11
@roxdanila roxdanila added enhancement New feature or request chore in-review and removed enhancement New feature or request labels Mar 22, 2024
@shark0der shark0der force-pushed the feature/cover-products-contract-rebased branch 3 times, most recently from b90592e to b1aea0a Compare March 29, 2024 14:51
@roxdanila roxdanila marked this pull request as draft April 1, 2024 11:22
@roxdanila roxdanila changed the title Cover products contract rebased in progress: Cover products contract rebased Apr 1, 2024
@shark0der shark0der changed the title in progress: Cover products contract rebased Cover products contract Apr 1, 2024
@shark0der shark0der force-pushed the feature/cover-products-contract-rebased branch 2 times, most recently from 4d11315 to fce848c Compare April 1, 2024 13:31
@roxdanila roxdanila changed the title Cover products contract chore: Cover products contract Apr 2, 2024
@MilGard91 MilGard91 force-pushed the feature/cover-products-contract-rebased branch from bf854aa to 8fc3689 Compare April 16, 2024 08:30
@roxdanila roxdanila changed the title chore: Cover products contract feat: Cover products contract Jun 5, 2024
@MilGard91 MilGard91 force-pushed the feature/cover-products-contract-rebased branch from 7344e45 to 6d1238d Compare June 11, 2024 16:41
@roxdanila roxdanila marked this pull request as ready for review June 12, 2024 08:08
@shark0der shark0der force-pushed the feature/cover-products-contract-rebased branch from 17ec974 to da68d2c Compare July 4, 2024 15:37
shark0der
shark0der approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@shark0der shark0der left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR

shark0der and others added 16 commits July 8, 2024 12:12
@shark0der
Add product and product type metadata setters and getters
d3eb2cf
@shark0der
Cleanup Cover and CoverProducts custom errors and events
db66e4f
@shark0der
Rename the ProductDoesntExist error to ProductNotFound in Cover.sol
bb91de7
@shark0der
Fix the cover buy tests related to the ProductDeprecated error
82b1ee7
@shark0der
Add metadata functions to the interface and implement them in the mock
3263495
@shark0der
Fix metadata update logic
57b5bf9
@shark0der
Fix setProducts tests
a01862b
@shark0der
Fix setProductTypes tests
4a1fbda
@shark0der
Fix integration buyCover test
372119d
@shark0der
Add forgotten await
83d3564
@shark0der
Add cover products metadata tests
870166f
@shark0der
Skip product metadata update if the ipfs hash is empty when calling s…
bd2aced 
…etProducts()
@shark0der
Add metadata migration script
baae9ea
@shark0der
Only keep the latest metadata update in the metadata migration script
83ff653
@shark0der
Merge pull request #1171 from NexusMutual/feat/move-ipfs-hashes-to-st…
42d7582 
…orage

Feature: Move ipfs hashes to storage
@shark0der
Remove overriding this with implementation contracts
68e3f78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shark0der shark0der shark0der approved these changes

@roxdanila roxdanila Awaiting requested review from roxdanila

Assignees
No one assigned
Labels
cover-products feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce size of the Cover.sol contract
4 participants
@MilGard91 @shark0der @roxdanila @danoctavian