Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove whitespace in Cover Assets csv #1142

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

rackstar
Copy link
Contributor

Context

Removes whitespaces to "Cover Assets" entry in the csv file

Changes proposed in this pull request

  • add regex to remove whitespace

Test plan

  • tested regex locally

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@rackstar rackstar requested a review from roxdanila June 18, 2024 15:34
@rackstar rackstar self-assigned this Jun 18, 2024
@roxdanila roxdanila force-pushed the fix/set-products-script-metadata-path branch from 19af08a to 9b72a36 Compare June 18, 2024 15:58
@roxdanila roxdanila merged commit 4792881 into release-candidate Jun 18, 2024
6 checks passed
@roxdanila roxdanila deleted the fix/set-products-script-metadata-path branch June 18, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants