Fix: Add the current globalCapacityFactor to store #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MilGard91
force-pushed
the
fix/cover-global-capacity-factor
branch
from
a07b290
to
1157b27
Compare
shark0der
reviewed
Jan 11, 2023
contracts/modules/cover/Cover.sol
Outdated
| @@ -390,7 +391,8 @@ contract Cover is ICover, MasterAwareV2, IStakingPoolBeacon, ReentrancyGuard { | |||
| start.toUint32(), | |||
| period.toUint32(), | |||
| productType.gracePeriod, | |||
| 0 // global rewards ratio | |||
| 0, // global rewards ratio | |||
| globalCapacityRatio | |||
There was a problem hiding this comment.
Technically we won't burn any staking pool so the amount here is irelevant, but since we're (hypothetically) divide by it, can you set this to 1, please?
shark0der
changed the title
shark0der
force-pushed
the
fix/cover-global-capacity-factor
branch
from
f43ea8c
to
a351657
Compare
MilGard91
force-pushed
the
fix/cover-global-capacity-factor
branch
2 times, most recently
from
9cc7c42
to
0246b62
Compare
shark0der
force-pushed
the
fix/cover-global-capacity-factor
branch
2 times, most recently
from
dbacaf9
to
7b22c17
Compare
shark0der
approved these changes
Jan 16, 2023
- legacy cover globalCapacityRatio
- cleaning up tests
shark0der
force-pushed
the
fix/cover-global-capacity-factor
branch
from
7b22c17
to
6ddf477
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
closing #566
Changes proposed in this pull request
Adding
globalCapacityFactorto segments of the Cover to be used when burning stake.Test plan
Test expanded with test with change of globalCapacityFactor before burn stake
Checklist
Review
When reviewing a PR, please indicate intention in comments using the following emojis: