-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration: LegacyPooledStaking changes & asserts in migration.js & scripts #691
Merged
shark0der
merged 75 commits into
nexus-v2
from
fix/migration-v2-stakingpool-pricing-asserts
Mar 3, 2023
Merged
Migration: LegacyPooledStaking changes & asserts in migration.js & scripts #691
shark0der
merged 75 commits into
nexus-v2
from
fix/migration-v2-stakingpool-pricing-asserts
Mar 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00d738c
to
6260121
Compare
6260121
to
4c5ab76
Compare
4c5ab76
to
05c82bf
Compare
danoctavian
commented
Feb 8, 2023
danoctavian
commented
Feb 8, 2023
danoctavian
commented
Feb 9, 2023
danoctavian
commented
Feb 9, 2023
danoctavian
commented
Feb 9, 2023
danoctavian
commented
Feb 9, 2023
danoctavian
commented
Feb 9, 2023
danoctavian
commented
Feb 9, 2023
danoctavian
commented
Feb 9, 2023
danoctavian
commented
Feb 9, 2023
roxdanila
reviewed
Feb 9, 2023
6beb2e6
to
6810aa7
Compare
eae8686
to
6810aa7
Compare
fee3aed
to
1dd9861
Compare
fe5d3ab
to
9abaa5d
Compare
b733d40
to
5e27fad
Compare
9abaa5d
to
36f5202
Compare
shark0der
reviewed
Feb 10, 2023
…takingProduct as constructor arg
79bc35c
to
46209dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Issues:
Pricing assertions + any other assertions for StakingPools: #608
Call pushRewards: #722
Changes proposed in this pull request
This change fixes the assertions around migrated products and their prices in V2 pools.
A read function is added to LegacyStakingPool that serves only 1 purpose: to check the validity of the migrated prices. (it's a view so won't affect anything else).
Test plan
Update and run the fork test.
Checklist
Review
When reviewing a PR, please indicate intention in comments using the following emojis: