Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration: LegacyPooledStaking changes & asserts in migration.js & scripts #691

Merged
merged 75 commits into from
Mar 3, 2023

Conversation

danoctavian
Copy link
Contributor

@danoctavian danoctavian commented Feb 6, 2023

Context

Issues:

Pricing assertions + any other assertions for StakingPools: #608
Call pushRewards: #722

Changes proposed in this pull request

This change fixes the assertions around migrated products and their prices in V2 pools.

A read function is added to LegacyStakingPool that serves only 1 purpose: to check the validity of the migrated prices. (it's a view so won't affect anything else).

Test plan

Update and run the fork test.

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@danoctavian danoctavian force-pushed the fix/migration-v2-stakingpool-pricing-asserts branch from 00d738c to 6260121 Compare February 6, 2023 16:58
@danoctavian danoctavian marked this pull request as ready for review February 6, 2023 17:04
@danoctavian danoctavian force-pushed the fix/migration-v2-stakingpool-pricing-asserts branch from 6260121 to 4c5ab76 Compare February 7, 2023 09:18
@roxdanila roxdanila linked an issue Feb 7, 2023 that may be closed by this pull request
@roxdanila roxdanila force-pushed the fix/migration-v2-stakingpool-pricing-asserts branch from 4c5ab76 to 05c82bf Compare February 8, 2023 09:54
test/fork/migration-v2.js Outdated Show resolved Hide resolved
test/fork/migration-v2.js Outdated Show resolved Hide resolved
test/fork/migration-v2.js Outdated Show resolved Hide resolved
test/fork/migration-v2.js Outdated Show resolved Hide resolved
test/fork/migration-v2.js Outdated Show resolved Hide resolved
test/fork/migration-v2.js Outdated Show resolved Hide resolved
test/fork/migration-v2.js Outdated Show resolved Hide resolved
test/fork/migration-v2.js Outdated Show resolved Hide resolved
@roxdanila roxdanila force-pushed the fix/migration-v2-stakingpool-pricing-asserts branch from 6beb2e6 to 6810aa7 Compare February 9, 2023 12:19
@danoctavian danoctavian force-pushed the fix/migration-v2-stakingpool-pricing-asserts branch from eae8686 to 6810aa7 Compare February 9, 2023 13:45
@roxdanila roxdanila force-pushed the fix/migration-v2-stakingpool-pricing-asserts branch from fee3aed to 1dd9861 Compare February 10, 2023 09:19
@roxdanila roxdanila self-assigned this Feb 10, 2023
@roxdanila roxdanila changed the base branch from nexus-v2 to feat/start-staking-pools-at-one February 10, 2023 14:24
@roxdanila roxdanila force-pushed the fix/migration-v2-stakingpool-pricing-asserts branch from fe5d3ab to 9abaa5d Compare February 10, 2023 14:24
@shark0der shark0der force-pushed the feat/start-staking-pools-at-one branch 2 times, most recently from b733d40 to 5e27fad Compare February 10, 2023 15:37
Base automatically changed from feat/start-staking-pools-at-one to nexus-v2 February 10, 2023 15:48
@shark0der shark0der force-pushed the fix/migration-v2-stakingpool-pricing-asserts branch from 9abaa5d to 36f5202 Compare February 10, 2023 15:52
@shark0der shark0der force-pushed the fix/migration-v2-stakingpool-pricing-asserts branch from 79bc35c to 46209dc Compare March 3, 2023 11:38
@shark0der shark0der merged commit 6b0fbb4 into nexus-v2 Mar 3, 2023
@shark0der shark0der deleted the fix/migration-v2-stakingpool-pricing-asserts branch March 3, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants