Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase total active cover amount when migrating covers #814

Merged
merged 7 commits into from Mar 16, 2023
Merged

Increase total active cover amount when migrating covers #814

merged 7 commits into from Mar 16, 2023

Conversation

danoctavian
Copy link
Contributor

@danoctavian danoctavian commented Mar 13, 2023 •
edited

Context

Fix issue with migrating a V1 cover to V2 where active cover amount is not properly increased.

Changes proposed in this pull request

Change Cover.sol to include the fix

Test plan

Run a fork test to test the migrated covers for FTX and Euler Finance.

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@danoctavian danoctavian force-pushed the chore/fork-tests-for-migrated-covers-claim-process branch 4 times, most recently from 11c109e to 1799b89 Compare March 14, 2023 00:18
@danoctavian danoctavian marked this pull request as ready for review March 14, 2023 00:20
@danoctavian danoctavian force-pushed the chore/fork-tests-for-migrated-covers-claim-process branch from 1799b89 to f927ac3 Compare March 14, 2023 00:25
@danoctavian danoctavian force-pushed the chore/fork-tests-for-migrated-covers-claim-process branch 6 times, most recently from ac05628 to f51c377 Compare March 15, 2023 01:14
@danoctavian danoctavian force-pushed the chore/fork-tests-for-migrated-covers-claim-process branch 3 times, most recently from fc3c48e to 5362ab7 Compare March 16, 2023 09:17
@roxdanila roxdanila linked an issue Mar 16, 2023 that may be closed by this pull request
Bug in V1 cover migration - total active cover amount should be accounted for #820
Closed
@danoctavian danoctavian force-pushed the chore/fork-tests-for-migrated-covers-claim-process branch from 5362ab7 to 75ed15d Compare March 16, 2023 11:32
@danoctavian danoctavian force-pushed the chore/fork-tests-for-migrated-covers-claim-process branch from 3c08e0b to 0b8486a Compare March 16, 2023 11:43
@shark0der shark0der changed the title Chore/fork tests for migrated covers claim process Increase active cover amount for migrated covers Mar 16, 2023
@shark0der shark0der changed the title Increase active cover amount for migrated covers Increase total active cover amount when migrating covers Mar 16, 2023
@shark0der shark0der merged commit d6ce44b into nexus-v2 Mar 16, 2023
@shark0der shark0der deleted the chore/fork-tests-for-migrated-covers-claim-process branch March 16, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shark0der shark0der shark0der approved these changes

@roxdanila roxdanila Awaiting requested review from roxdanila

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in V1 cover migration - total active cover amount should be accounted for
2 participants
@danoctavian @shark0der