-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Expand Cover contract with expireCover
#868
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MilGard91
changed the title
Expand Cover contract with
Feature: Expand Cover contract with May 15, 2023
expireCover
expireCover
roxdanila
reviewed
May 15, 2023
roxdanila
reviewed
May 15, 2023
roxdanila
reviewed
May 15, 2023
roxdanila
reviewed
May 15, 2023
MilGard91
force-pushed
the
feature/add-expire-cover
branch
3 times, most recently
from
May 18, 2023 10:21
19b0030
to
6a3bddb
Compare
shark0der
force-pushed
the
feature/add-expire-cover
branch
2 times, most recently
from
May 18, 2023 13:43
d01dcca
to
9b881fb
Compare
MilGard91
force-pushed
the
feature/add-expire-cover
branch
from
May 18, 2023 14:30
9b881fb
to
fd9b4b9
Compare
MilGard91
force-pushed
the
feature/add-expire-cover
branch
from
May 18, 2023 14:37
fd9b4b9
to
15506b2
Compare
MilGard91
force-pushed
the
feature/add-expire-cover
branch
from
May 18, 2023 14:42
15506b2
to
c742e5b
Compare
shark0der
requested changes
May 18, 2023
MilGard91
force-pushed
the
feature/add-expire-cover
branch
from
May 19, 2023 08:34
395273b
to
a5ebec0
Compare
MilGard91
force-pushed
the
feature/add-expire-cover
branch
from
May 19, 2023 12:18
33a2c25
to
faba74d
Compare
shark0der
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When cover expires is no way to refresh the capacity before the bucket expires
Issue: #863
Changes proposed in this pull request
Added
expireCover
that will expire cover even though the bucket didn't expire, so we can use the capcaity.Test plan
Added tests for
expireCover
function in integration tests.Checklist
Review
When reviewing a PR, please indicate intention in comments using the following emojis: