Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Expand Cover contract with expireCover #868

Merged
merged 15 commits into from
May 29, 2023

Conversation

MilGard91
Copy link
Contributor

@MilGard91 MilGard91 commented May 15, 2023

Context

When cover expires is no way to refresh the capacity before the bucket expires

Issue: #863

Changes proposed in this pull request

Added expireCover that will expire cover even though the bucket didn't expire, so we can use the capcaity.

Test plan

Added tests for expireCover function in integration tests.

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 馃嵃 = Nice to have but not essential.
  • 馃挕 = Suggestion or a comment based on personal opinion
  • 馃敤 = I believe this should be changed.
  • 馃 = I don鈥檛 understand something, do you mind giving me more context?
  • 馃殌 = Feedback

@MilGard91 MilGard91 requested a review from shark0der May 15, 2023 08:09
@MilGard91 MilGard91 linked an issue May 15, 2023 that may be closed by this pull request
@MilGard91 MilGard91 changed the title Expand Cover contract with expireCover Feature: Expand Cover contract with expireCover May 15, 2023
@MilGard91 MilGard91 force-pushed the feature/add-expire-cover branch 3 times, most recently from 19b0030 to 6a3bddb Compare May 18, 2023 10:21
@shark0der shark0der force-pushed the feature/add-expire-cover branch 2 times, most recently from d01dcca to 9b881fb Compare May 18, 2023 13:43
@MilGard91 MilGard91 requested a review from roxdanila May 18, 2023 14:31
@MilGard91 MilGard91 marked this pull request as ready for review May 18, 2023 14:31
contracts/interfaces/IStakingPool.sol Outdated Show resolved Hide resolved
contracts/interfaces/ICover.sol Outdated Show resolved Hide resolved
contracts/modules/cover/Cover.sol Show resolved Hide resolved
test/unit/StakingPool/requestAllocation.js Show resolved Hide resolved
contracts/modules/cover/Cover.sol Outdated Show resolved Hide resolved
contracts/modules/cover/Cover.sol Outdated Show resolved Hide resolved
test/integration/Cover/expireCover.js Outdated Show resolved Hide resolved
test/integration/Cover/expireCover.js Outdated Show resolved Hide resolved
test/integration/Cover/expireCover.js Outdated Show resolved Hide resolved
test/integration/Cover/expireCover.js Outdated Show resolved Hide resolved
@shark0der shark0der merged commit 911e667 into release-candidate May 29, 2023
5 checks passed
@shark0der shark0der deleted the feature/add-expire-cover branch May 29, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function to manually expire a cover
3 participants