Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add process expiration events #874

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

MilGard91
Copy link
Contributor

@MilGard91 MilGard91 commented Jun 12, 2023

Context

Issue: #864

Changes proposed in this pull request

Add event when bucket or tranche expires

Test plan

Added tests to check if the event is emitted.

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 馃嵃 = Nice to have but not essential.
  • 馃挕 = Suggestion or a comment based on personal opinion
  • 馃敤 = I believe this should be changed.
  • 馃 = I don鈥檛 understand something, do you mind giving me more context?
  • 馃殌 = Feedback

@MilGard91 MilGard91 requested a review from shark0der June 12, 2023 08:06
@MilGard91 MilGard91 changed the title Add process expiration events Feature: Add process expiration events Jun 12, 2023
@shark0der shark0der merged commit 2c60958 into release-candidate Jun 14, 2023
5 of 6 checks passed
@shark0der shark0der deleted the feature/expiration-event branch June 14, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add event when StakingPool.processExpirations() is called to be used for Dune Analytics tracking
2 participants