Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: allocation carry over #875

Merged
merged 4 commits into from
Jun 15, 2023
Merged

Conversation

shark0der
Copy link
Collaborator

Context

Issue #872

Changes proposed in this pull request

Carry over allocations from previous tranches.

Test plan

Added a test that fails with the current release-candidate and passes with the fix.

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 馃嵃 = Nice to have but not essential.
  • 馃挕 = Suggestion or a comment based on personal opinion
  • 馃敤 = I believe this should be changed.
  • 馃 = I don鈥檛 understand something, do you mind giving me more context?
  • 馃殌 = Feedback

@shark0der shark0der linked an issue Jun 13, 2023 that may be closed by this pull request
@shark0der shark0der marked this pull request as ready for review June 13, 2023 15:39
@shark0der shark0der changed the title Fix/allocation carry over Fix: allocation carry over Jun 13, 2023
@shark0der shark0der merged commit 4934d7d into release-candidate Jun 15, 2023
5 checks passed
@shark0der shark0der deleted the fix/allocation-carry-over branch June 15, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review extend deposit
3 participants