Fix: Expiration bucket check on cover expiration #878
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Due to a lax check on the expiration bucket id the expire cover could revert with an underflow since the allocations could have been already freed up.
Changes proposed in this pull request
This PR moves corrects the check and moves it earlier in the code to fail with a custom error instead.
Test plan
Added a new test that:
Before the fix it will fail with an underflow, with the fix it fails with a custom error.
Checklist
Review
When reviewing a PR, please indicate intention in comments using the following emojis: