Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make StakingViewer pull StakingProducts address from master #881

Conversation

shark0der
Copy link
Collaborator

Context

StakingViewer had StakingProducts as a constructor arg

Changes proposed in this pull request

Constructor arg is removed and the address is pulled from master contract instead.

Test plan

Please describe the tests cases that you ran to verify your changes. Add further instructions on
how to run them if needed (i.e. migration / deployment scripts, env vars, etc).

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 馃嵃 = Nice to have but not essential.
  • 馃挕 = Suggestion or a comment based on personal opinion
  • 馃敤 = I believe this should be changed.
  • 馃 = I don鈥檛 understand something, do you mind giving me more context?
  • 馃殌 = Feedback

@roxdanila roxdanila force-pushed the chore/staking-viewer-pull-staking-products-from-master branch from 9913058 to a9d642c Compare June 19, 2023 11:53
@shark0der shark0der merged commit ba67528 into release-candidate Jun 19, 2023
4 checks passed
@shark0der shark0der deleted the chore/staking-viewer-pull-staking-products-from-master branch June 19, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants