Bug: Fix fixed price product cover buys #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roxdanila
changed the title
|
to clarify there's 2 bug fixes here, because parameters were passed in the wrong order to calculateFixedPricePremium |
MilGard91
force-pushed
the
fix/fixed-price-products
branch
from
9561c36
to
d39aa69
Compare
roxdanila
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Marking products as being fixed price is currently being skipped on allocation requests.
Changes proposed in this pull request
Set the useFixedPrice boolean on the allocationRequest on buy cover.
Test plan
Added new tests to catch the issue
Checklist
Review
When reviewing a PR, please indicate intention in comments using the following emojis: