Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed /etc/letsencrypt from explicit volumes #3258

Merged
merged 1 commit into from Jan 14, 2024

Conversation

iBobik
Copy link
Contributor

@iBobik iBobik commented Oct 15, 2023

So it can be moved in other images using this as a base.

Fixes #3170

So it can be moved in other images using this as a base.

Fixes NginxProxyManager#3170
@jc21
Copy link
Member

jc21 commented Jan 8, 2024

CI is failing because the /etc/letsencrypt folder needs to be mounted and there's a check to enforce that.

Modify this file as part of your patch and add a named volume to the fullstack-* services, similar to npm_data volume.

@nginxproxymanagerci
Copy link

Docker Image for build 3 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-3258

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

@jc21 jc21 merged commit 9f16dae into NginxProxyManager:develop Jan 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ways to move letsencrypt storage to /data volume
2 participants