-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for ddns lookups for addresses in access lists #3364
Open
vari
wants to merge
8
commits into
NginxProxyManager:develop
Choose a base branch
from
vari:access-list-client-ddns-support
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added support for ddns lookups for addresses in access lists #3364
vari
wants to merge
8
commits into
NginxProxyManager:develop
from
vari:access-list-client-ddns-support
Commits on Apr 29, 2024
-
Initial pass at DDNS support for client addresses
This is a first pass attempt at adding support for using ddns (really any resolvable domain name) as the address in access list clients. This helps make it possible to restrict access to hosts using a dynamic public IP (e.g. allow access to a proxied host from your local network only via ddns address). Current approach is hacky since it was developed by manually replacing files in an existing npm docker container. Future commits will integrate this better and avoid needing to patch/intercept existing APIs. See associated PR for more details.
Configuration menu - View commit details
-
Copy full SHA for 5586709 - Browse repository at this point
Copy the full SHA 5586709View commit details -
Refactor and integrate ddns resolution with nginx module
Refactored ddns resolver so that no patching is done. nginx.js will automatically resolve ddns addresses if needed. Added dedicated logger scope for ddns resovler.
Configuration menu - View commit details
-
Copy full SHA for ec9eb0d - Browse repository at this point
Copy the full SHA ec9eb0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 972d158 - Browse repository at this point
Copy the full SHA 972d158View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33f41f7 - Browse repository at this point
Copy the full SHA 33f41f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 743cdd8 - Browse repository at this point
Copy the full SHA 743cdd8View commit details -
Update configs for active hosts only on ddns update
Other changes: - Fixed null property read error on clients (when switching to public access) - Use separate `resolvedAddress` field for resolved IP instead of overwriting address - Reduced ddns log verbosity
Configuration menu - View commit details
-
Copy full SHA for 7b09fef - Browse repository at this point
Copy the full SHA 7b09fefView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b0ff57 - Browse repository at this point
Copy the full SHA 3b0ff57View commit details -
Configuration menu - View commit details
-
Copy full SHA for e317900 - Browse repository at this point
Copy the full SHA e317900View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.