Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Access List Form #975

Merged

Conversation

michaelgaultjr
Copy link
Contributor

Changes

  • Added button to add additional Usernames/Passwords to Access Lists.
  • Added button to add additional IPs to Access Lists.
  • Added Reference to Nginx documentation in Access List "Authorization" tab.
  • Added Reference to Nginx documentation in Access List "Access" tab.

Reason for Changes

There are many situations where you'd want to have more than 4 IPs in an access list, this wasn't possible within NPM.
This PR makes that possible while adding references to the Nginx documentation on how to use the features.

Fixed Issues

#615
#822

@jc21
Copy link
Member

jc21 commented Mar 25, 2021

Docker Image for build 1 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-975

@jc21 jc21 changed the base branch from master to develop April 28, 2021 23:34
@jc21
Copy link
Member

jc21 commented Apr 29, 2021

Docker Image for build 2 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-975

@jc21 jc21 added the requires-verification Waiting for one or more people to confirm the fix label Apr 29, 2021
Copy link
Member

@jc21 jc21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. Just these 2 comments I noticed while testing. Without these changes it means people will load the documentation links in the same tab/window and lose their changes.

frontend/js/app/nginx/access/form.ejs Outdated Show resolved Hide resolved
frontend/js/app/nginx/access/form.ejs Outdated Show resolved Hide resolved
@jc21
Copy link
Member

jc21 commented May 6, 2021

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires-verification Waiting for one or more people to confirm the fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants