Remove move() in ImageOverlay #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was causing the full screen image overlay to appear on the "primary display" vs. the actual display nheko is running on. removing the move() call makes the overlay follow the window.
deepbluev7
reviewed
Feb 13, 2020
Lymkwi
pushed a commit
to Lymkwi/nheko
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was causing the full screen image overlay to appear on the "primary display" vs. the actual display nheko is running on.
removing the move() call makes the overlay follow the window around.
I wasn't able to get the
parent()->screenmethod working first go.I tested on plasma, Nico in the matrix room said he'd give it a shot in his DE to see if it works there as well.