Presence support #216
Merged
Presence support #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It currently causes severe performance issues in synapse as well as many random resets, so this is disabled until those issues are resolved.
This still leaves out setting a client to online/offline, since that seems to be causing the CPU issues with synapse.
|
I reenabled setting a custom status, since that doesn't seem to cause performance issues in itself. |
|
Note to @redsky17: I also included a fix for the scale factor setting as the last commit, because it would have caused merge conflicts. |
redsky17
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly allowing the user to change presence causes severe performance issues, so this is disabled for now. Apart from that, it does currently display online status and status_msg of other users (may not always be up to date though. For performance reasons it only updates it on room switch). Setting your own presence and status message requires the following bugs to be fixed:
matrix-org/synapse#2245
matrix-org/synapse#5336
matrix-org/synapse#3971
There are also some optimizations that need to be done in synapse, so that setting a different presence doesn't cause a presence spam of 100Hz or more. (For every sync basically, as fast as synapse can sync)