Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(perp): Make the collateral denom a stateful collections.Item #1640

Closed
Unique-Divine opened this issue Oct 17, 2023 · 0 comments · Fixed by #1669
Closed

feat(perp): Make the collateral denom a stateful collections.Item #1640

Unique-Divine opened this issue Oct 17, 2023 · 0 comments · Fixed by #1669
Assignees
@matthiasmatt

Comments

@Unique-Divine
Copy link
Member

Unique-Divine commented Oct 17, 2023 •
edited
Loading

The collateral denom for x/perp needs to be a collections.Item / KeySet to make it configurable.

  • This is necessary for setting the address for NUSD, which would look like "tf/[contract-addr]/nusd".
  • This change would also lower the possibility of mistakes arising from hard-coded denominations on all of the bank transfer logic in x/perp.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthiasmatt matthiasmatt

Labels
None yet
Projects
⚛️ Nibiru Chain (Hougyoku)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(perp): Create query for the stateful collateral metadata NibiruChain/nibiru
2 participants
@Unique-Divine @matthiasmatt