feat(vpool): add event fields for web app #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NibiruHeisenberg
approved these changes
Oct 22, 2022
Might as well toss it in. One sec |
Unique-Divine
added a commit
that referenced
this pull request
Oct 22, 2022
This reverts commit db623d7.
NibiruHeisenberg
pushed a commit
that referenced
this pull request
Oct 23, 2022
* add fields to ReserveSnapshotSavedEvent * (CHANGELOG): add PR number to description * fix(CHANGELOG) * refactor: Make names consistent for BlockTimestamp field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
BlockHeight,MarkPrice, andBlockTimestampto the snapshot event releaed in the perp module'sEndBlocker. This will make the event more similar to common Ethereum tables (example Aave Deposits Table)Purpose
Right now, two queries are required to get the full information needed to graph price data in the web app. The GraphQL query looks like this:
This query requires two separate DB reads (one for the timestamps and one for the reserves) and some parsing of the arrays after the query to iterate through and compute the mark price values.
By adding the few proto fields described in the PR description, the single query is much easier to work with in downstream applications.