Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ibc): (1) IBC compatibility to app.go. (2) CLI enabled. (3) IBC tests. | Realu/ibc #243

Merged
merged 48 commits into from
Jun 11, 2022

Conversation

Unique-Divine
Copy link
Member

@Unique-Divine Unique-Divine commented Apr 23, 2022

Task Summary

The CLI seems to work.

image

image

Integrating the IBC module

  • Add required modules to the module.BasicManager
  • Define additional Keeper fields for the new modules on the App type
  • Add the module's StoreKeys and initialize their Keepers
  • Set up corresponding routers and routes for the ibc module
  • Add the modules to the module manager
  • Add modules to Begin/EndBlockers and InitGenesis
  • Update the module SimulationManager to enable simulations
  • The capability module must be declared first in SetOrderInitGenesis

ibc-go testing TestingApp

  • Adhere to ibc-go TestingApp interface so that we can plug this into integration tests.
  • TestInitialization: Setup of clients, connections, and channels work
  • TestClient_BeginBlocker: local host light client initializes properly and state increments properly after several blocks

Related

@Unique-Divine Unique-Divine changed the title Realu/ibc feat (ibc): Add IBC compatibility to app.go | Realu/ibc Apr 23, 2022
@Unique-Divine Unique-Divine self-assigned this Apr 23, 2022
@NibiruHeisenberg NibiruHeisenberg requested a review from a team April 23, 2022 19:08
app/app.go Outdated Show resolved Hide resolved
app/ante.go Show resolved Hide resolved
@Unique-Divine Unique-Divine added this to the alpha milestone Apr 29, 2022
@Unique-Divine Unique-Divine added the ⚠️ do not merge On hold for merge or not desired label May 4, 2022
@Unique-Divine Unique-Divine changed the title feat (ibc): Add IBC compatibility to app.go | Realu/ibc feat(ibc): Add IBC compatibility to app.go | Realu/ibc Jun 10, 2022
@NibiruChain NibiruChain deleted a comment from AgentSmithMatrix Jun 10, 2022
@Unique-Divine Unique-Divine changed the title feat(ibc): Add IBC compatibility to app.go | Realu/ibc feat(ibc): (1) IBC compatibility to app.go. (2) CLI enabled. (3) IBC tests. | Realu/ibc Jun 10, 2022
@Unique-Divine Unique-Divine merged commit 8974e1a into master Jun 11, 2022
@Unique-Divine Unique-Divine deleted the realu/ibc branch June 11, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants