docs(perp): Specification for client and concepts. #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unique-Divine
added
type: docs
…2) Add TODOs and polish other sections.
Unique-Divine
commented
Jun 10, 2022
| @@ -134,15 +134,15 @@ Returns: | |||
| toll (sdk.Int): Amount of tokens transferred to the the fee pool. | |||
| spread (sdk.Int): Amount of tokens transferred to the PerpEF. | |||
| */ | |||
| func (k Keeper) CalcPerpTxFee(ctx sdk.Context, quoteAmt sdk.Dec) (toll sdk.Int, spread sdk.Int, err error) { | |||
| func (k Keeper) CalcPerpTxFee(ctx sdk.Context, quoteAmt sdk.Dec) (toll sdk.Int, spread sdk.Int) { | |||
There was a problem hiding this comment.
This error value was unused.
Unique-Divine
commented
Jun 10, 2022
| @@ -231,8 +231,6 @@ type VpoolKeeper interface { | |||
| pair common.AssetPair, | |||
| ) (price sdk.Dec, err error) | |||
|
|
|||
| CalcPerpTxFee(ctx sdk.Context, pair common.AssetPair, quoteAmt sdk.Int, | |||
There was a problem hiding this comment.
This function is not part of the VpoolKeeper. It's part of the PerpKeeper.
Unique-Divine
commented
Jun 10, 2022
| @@ -28,21 +28,6 @@ type Keeper struct { | |||
| pricefeedKeeper types.PricefeedKeeper | |||
| } | |||
|
|
|||
| //CalcPerpTxFee calculates the total tx fee for exchanging 'quoteAmt' of tokens on | |||
There was a problem hiding this comment.
This function is unimplemented and unused.
Unique-Divine
changed the title
5 tasks
Unique-Divine
changed the title
NibiruHeisenberg
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related