Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(vpool): Replace vpool events with typed events #588

Merged
merged 5 commits into from
Jun 10, 2022
Merged

refactor(vpool): Replace vpool events with typed events #588

merged 5 commits into from
Jun 10, 2022

Conversation

NibiruHeisenberg
Copy link
Contributor

@NibiruHeisenberg NibiruHeisenberg commented Jun 10, 2022 •
edited

  • add ReserveSnapshotSavedEvent event
  • add SwapQuoteForBaseEvent event
  • add SwapBaseForQuoteEvent event
  • add pair field to events
  • remove block_height field from events since the transaction output will already have that (it's redundant information for clients subscribing to websocket events)

@NibiruHeisenberg NibiruHeisenberg requested a review from a team as a code owner June 10, 2022 19:38
@NibiruHeisenberg NibiruHeisenberg self-assigned this Jun 10, 2022
@NibiruHeisenberg NibiruHeisenberg added x/vpool type: refactor A code change that neither fixes a bug nor adds a feature labels Jun 10, 2022
@NibiruHeisenberg NibiruHeisenberg linked an issue Jun 10, 2022 that may be closed by this pull request
refactor(vpool): used typed events #565
Closed
@Unique-Divine Unique-Divine merged commit 7fb2845 into master Jun 10, 2022
@Unique-Divine Unique-Divine deleted the refactor/vpool-event-type branch June 10, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Unique-Divine Unique-Divine Unique-Divine approved these changes

Assignees

@NibiruHeisenberg NibiruHeisenberg

Labels
type: refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(vpool): used typed events
2 participants
@NibiruHeisenberg @Unique-Divine