Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(perp): Make perp events typed #590

Merged
merged 19 commits into from
Jun 11, 2022
Merged

refactor(perp): Make perp events typed #590

merged 19 commits into from
Jun 11, 2022

Conversation

NibiruHeisenberg
Copy link
Contributor

@NibiruHeisenberg NibiruHeisenberg commented Jun 11, 2022 •
edited by Unique-Divine

Summary

  • add PositionLiquidatedEvent
  • add MarginChangedEvent
  • remove MarginRatioChangedEvent
  • remove TransferEvent
    • BankKeeper already emits this, and we were clobbering it
  • add test assertions that the new typed events were being emitted
  • add AddMargin unit tests
  • remove unused code

Issues

@NibiruHeisenberg NibiruHeisenberg requested a review from a team as a code owner June 11, 2022 05:57
@NibiruHeisenberg NibiruHeisenberg marked this pull request as draft June 11, 2022 05:59
@NibiruHeisenberg NibiruHeisenberg marked this pull request as ready for review June 11, 2022 15:39
@NibiruHeisenberg NibiruHeisenberg self-assigned this Jun 11, 2022
@NibiruHeisenberg NibiruHeisenberg added type: tests Unit and integration test additions and improvements type: refactor A code change that neither fixes a bug nor adds a feature x/perp labels Jun 11, 2022
Unique-Divine
Unique-Divine approved these changes Jun 11, 2022
View reviewed changes
x/testutil/events/testutil.go Outdated Show resolved Hide resolved
@Unique-Divine Unique-Divine merged commit b1eb4fc into master Jun 11, 2022
@Unique-Divine Unique-Divine deleted the refactor/perp-event-types branch June 11, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Unique-Divine Unique-Divine Unique-Divine approved these changes

Assignees

@NibiruHeisenberg NibiruHeisenberg

Labels
type: refactor A code change that neither fixes a bug nor adds a feature type: tests Unit and integration test additions and improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

epic: ABCI event refactors and quality improvements refactor(perp): use typed events
2 participants
@NibiruHeisenberg @Unique-Divine