Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: cli(lockup) add tests #594

Merged
merged 11 commits into from
Jun 18, 2022
Merged

test: cli(lockup) add tests #594

merged 11 commits into from
Jun 18, 2022

Conversation

testinginprod
Copy link
Collaborator

closes: #502

@testinginprod testinginprod requested a review from a team as a code owner June 11, 2022 19:41
@Unique-Divine Unique-Divine changed the title [lockup] add: cli tests cli(lockup): add tests Jun 12, 2022
@Unique-Divine Unique-Divine added CLI type: tests Unit and integration test additions and improvements labels Jun 12, 2022
x/lockup/client/cli/cli_test.go Outdated Show resolved Hide resolved
x/lockup/client/cli/cli_test.go Outdated Show resolved Hide resolved
@testinginprod
Copy link
Collaborator Author

testinginprod commented Jun 16, 2022

@AgentSmithMatrix, @NibiruHeisenberg I cleaned up the tests + added some helper functions which I think make testing CLI commands a little more easier and less verbose, whilst still providing the same extensibility.

In case we're happy with the approach I will merge it and move the other CLI tests to use the same approach.

@testinginprod testinginprod changed the title cli(lockup): add tests test: cli(lockup) add tests Jun 18, 2022
@testinginprod testinginprod merged commit 2a68dc5 into master Jun 18, 2022
@testinginprod testinginprod deleted the mercilex/lockup-cli-tests branch June 18, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: tests Unit and integration test additions and improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lockup]: cli tests
4 participants