Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to burn stables for collateral and governance token #61

Merged
merged 36 commits into from
Mar 30, 2022

Conversation

matthiasmatt
Copy link
Contributor

@matthiasmatt matthiasmatt commented Mar 28, 2022

Description

Include keeper and message to allow user to burn a stable coin in exchange for collateral and governance tokens.

Fixes #54

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Message unit test
  • Keeper unit test
  • Test of burn logic with prifeed integration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

mdarblade and others added 21 commits March 28, 2022 19:02
fix (Stablecoin/burn): Merge master. Restore passing state. Postpone MsgRespone tests until we have pricefeed keeper tests.
@Unique-Divine Unique-Divine requested a review from a team March 30, 2022 00:04
@Unique-Divine Unique-Divine marked this pull request as ready for review March 30, 2022 00:05
Copy link
Collaborator

@testinginprod testinginprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lookgs good at logic level, some nits only :)

x/stablecoin/types/burn_msg.go Show resolved Hide resolved
x/stablecoin/types/burn_msg_test.go Show resolved Hide resolved
proto/stablecoin/tx.proto Show resolved Hide resolved
proto/stablecoin/tx.proto Show resolved Hide resolved
x/stablecoin/keeper/burn_stable.go Show resolved Hide resolved
x/stablecoin/keeper/burn_stable.go Outdated Show resolved Hide resolved
x/stablecoin/keeper/mint_stable.go Outdated Show resolved Hide resolved
x/stablecoin/keeper/msg_server.go Show resolved Hide resolved
x/stablecoin/types/burn_msg.go Outdated Show resolved Hide resolved
x/stablecoin/types/burn_msg.go Outdated Show resolved Hide resolved
x/stablecoin/keeper/burn_stable.go Show resolved Hide resolved
x/stablecoin/keeper/burn_stable_test.go Show resolved Hide resolved
x/stablecoin/keeper/burn_stable_test.go Outdated Show resolved Hide resolved
x/stablecoin/keeper/burn_stable_test.go Outdated Show resolved Hide resolved
x/stablecoin/keeper/burn_stable_test.go Show resolved Hide resolved
x/stablecoin/keeper/mint_stable.go Outdated Show resolved Hide resolved
x/stablecoin/keeper/mint_stable_test.go Outdated Show resolved Hide resolved
x/stablecoin/keeper/mint_stable_test.go Outdated Show resolved Hide resolved
x/stablecoin/keeper/msg_server.go Show resolved Hide resolved
x/stablecoin/types/expected_keepers_test.go Show resolved Hide resolved
@Unique-Divine Unique-Divine merged commit 8148850 into master Mar 30, 2022
@Unique-Divine Unique-Divine deleted the stablecoin/burn branch March 30, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Burn USDM given the MsgBurn
5 participants