Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(perp): Fix PositionChangedEvent #613

Merged
merged 10 commits into from
Jun 16, 2022
Merged

fix(perp): Fix PositionChangedEvent #613

merged 10 commits into from
Jun 16, 2022

Conversation

NibiruHeisenberg
Copy link
Contributor

@NibiruHeisenberg NibiruHeisenberg commented Jun 15, 2022 •
edited

  • refactor traderAddress and liquidatorAddress to string instead of bytes
  • send proper PositionNotional
  • add ClosePosition unit tests that asserts the event was emitted
  • refactor some existing PerpKeeper methods

@NibiruHeisenberg NibiruHeisenberg requested a review from a team as a code owner June 15, 2022 15:33
@NibiruHeisenberg NibiruHeisenberg marked this pull request as draft June 15, 2022 15:33
@NibiruHeisenberg
Copy link
Contributor Author

cc @onikonychev

@NibiruHeisenberg NibiruHeisenberg self-assigned this Jun 15, 2022
@NibiruHeisenberg NibiruHeisenberg changed the title refactor(perp): Fix events for liquidation refactor(perp): Fix PositionChangedEvent Jun 16, 2022
@NibiruHeisenberg NibiruHeisenberg changed the title refactor(perp): Fix PositionChangedEvent fix(perp): Fix PositionChangedEvent Jun 16, 2022
@NibiruHeisenberg NibiruHeisenberg marked this pull request as ready for review June 16, 2022 15:35
testinginprod
testinginprod approved these changes Jun 16, 2022
View reviewed changes
Copy link
Collaborator

@testinginprod testinginprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding extra coverage on ClosePosition

@NibiruHeisenberg NibiruHeisenberg merged commit 476baeb into master Jun 16, 2022
@NibiruHeisenberg NibiruHeisenberg deleted the refactor/perp/events branch June 16, 2022 16:43
@NibiruHeisenberg NibiruHeisenberg mentioned this pull request Jun 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testinginprod testinginprod testinginprod approved these changes

@onikonychev onikonychev Awaiting requested review from onikonychev

Assignees

@NibiruHeisenberg NibiruHeisenberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NibiruHeisenberg @testinginprod