-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use withdraw to transfer funds from vault to trader #633
Conversation
@@ -90,7 +90,7 @@ func (k Keeper) SettlePosition( | |||
if err != nil { | |||
panic(err) // NOTE(mercilex): must never happen | |||
} | |||
err = k.BankKeeper.SendCoinsFromModuleToAccount( | |||
err = k.BankKeeper.SendCoinsFromModuleToAccount( // NOTE(mercilex): withdraw is not applied here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct @NibiruHeisenberg ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. We probably won't be running settlements anytime soon either.
@@ -90,7 +90,7 @@ func (k Keeper) SettlePosition( | |||
if err != nil { | |||
panic(err) // NOTE(mercilex): must never happen | |||
} | |||
err = k.BankKeeper.SendCoinsFromModuleToAccount( | |||
err = k.BankKeeper.SendCoinsFromModuleToAccount( // NOTE(mercilex): withdraw is not applied here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. We probably won't be running settlements anytime soon either.
closes: #619