Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(perp): Add blockHeight and blockTimeMs to PositionChangedEvent #634

Merged
merged 1 commit into from
Jun 17, 2022
Merged

feat(perp): Add blockHeight and blockTimeMs to PositionChangedEvent #634

merged 1 commit into from
Jun 17, 2022

Conversation

NibiruHeisenberg
Copy link
Contributor

closes #608

@NibiruHeisenberg NibiruHeisenberg requested a review from a team as a code owner June 17, 2022 14:05
@NibiruHeisenberg NibiruHeisenberg self-assigned this Jun 17, 2022
testinginprod
testinginprod reviewed Jun 17, 2022
View reviewed changes
Copy link
Collaborator

@testinginprod testinginprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this fields are redundant, considering that events are pulled out of a TX which is pulled out of a block whihc contains this information.

@AgentSmithMatrix AgentSmithMatrix merged commit 4c3f1e6 into master Jun 17, 2022
@AgentSmithMatrix AgentSmithMatrix deleted the refactor/events/position-changed branch June 17, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testinginprod testinginprod testinginprod left review comments

@AgentSmithMatrix AgentSmithMatrix AgentSmithMatrix approved these changes

Assignees

@NibiruHeisenberg NibiruHeisenberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(events): Add timestamp to PositionChanged event
3 participants
@NibiruHeisenberg @AgentSmithMatrix @testinginprod