Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devops): Release workflow #652

Merged
merged 14 commits into from
Jun 24, 2022
Merged

fix(devops): Release workflow #652

merged 14 commits into from
Jun 24, 2022

Conversation

NibiruHeisenberg
Copy link
Contributor

@NibiruHeisenberg NibiruHeisenberg commented Jun 23, 2022

Fix the error on master's release workflow.

@NibiruHeisenberg NibiruHeisenberg requested a review from a team as a code owner June 23, 2022 20:55
@NibiruHeisenberg NibiruHeisenberg added the ⚠️ do not merge On hold for merge or not desired label Jun 23, 2022
@NibiruHeisenberg NibiruHeisenberg added devops and removed ⚠️ do not merge On hold for merge or not desired labels Jun 23, 2022
@NibiruHeisenberg NibiruHeisenberg self-assigned this Jun 23, 2022
@NibiruHeisenberg NibiruHeisenberg linked an issue Jun 23, 2022 that may be closed by this pull request
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the fix. The default value for fetch-depth was 1, which didn't pull enough code for ignite cli to build the binary.

key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-go-
cache: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/setup-go@v3 offers a simpler way to cache build files and packages.

@matthiasmatt matthiasmatt merged commit 28e50de into master Jun 24, 2022
@matthiasmatt matthiasmatt deleted the fix/release-workflow branch June 24, 2022 15:27
@NibiruHeisenberg NibiruHeisenberg restored the fix/release-workflow branch July 12, 2022 20:25
@NibiruHeisenberg NibiruHeisenberg deleted the fix/release-workflow branch July 12, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test(PoC): Release branch and conventional commit.
2 participants