or gate close path and draw links before nodes #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nic30
reviewed
Mar 28, 2021
| @@ -189,6 +189,8 @@ export default class HwSchematic { | |||
| _applyLayout() { | |||
| var root = this.root; | |||
|
|
|||
| this._applyLayoutLinks(); | |||
There was a problem hiding this comment.
Why was the move required?
(It is not a problem, I am asking from a curiosity.)
There was a problem hiding this comment.
Hi. Moving applyLayoutLinks means that the links are drawn before (ie underneath) the nodes. Drawing the node over the top of the link hides the small excursion of the link into the node (the output link in the top picture extends slightly into the node). It's a bit hacky - but probably better than trying to alter the start/end coordinates for each link to match a specific node type.
There was a problem hiding this comment.
PS: my understanding is that D3/SVG has no capability to specifically assign a z-order independent of creation/append order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two tiny changes to (microscopically :-) )improve image appearance
eg
Before:
After:
