Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make invalid prop type warnings more specific if they are falsy #11289 #3

Closed
NicBonetto opened this issue Oct 20, 2017 · 0 comments
Closed

Make invalid prop type warnings more specific if they are falsy #11289 #3

NicBonetto opened this issue Oct 20, 2017 · 0 comments

Comments

@NicBonetto
Copy link
Owner

Make error more precise.
NicBonetto added a commit that referenced this issue Oct 20, 2017
@NicBonetto
Modified tests and corrected error message. #3
2653595
NicBonetto added a commit that referenced this issue Oct 20, 2017
@NicBonetto
Fixed syntax issues. #3
8de9a20
NicBonetto added a commit that referenced this issue Oct 20, 2017
@NicBonetto
Modified test. #3
4ce5b49
NicBonetto added a commit that referenced this issue Oct 20, 2017
@NicBonetto
Prettified. #3
3d4724e
NicBonetto added a commit that referenced this issue Oct 24, 2017
@NicBonetto
Changed warning message to handle true and false boolean values. #3
449b98d
NicBonetto added a commit that referenced this issue Oct 24, 2017
@NicBonetto
Changed test to contain undefined instead of value. #3
bb7978c
NicBonetto added a commit that referenced this issue Oct 26, 2017
@NicBonetto
Simplified branch structure. #3
05ecf0a
NicBonetto added a commit that referenced this issue Oct 26, 2017
@NicBonetto
Refactored branching logic. #3
e18a235
NicBonetto added a commit that referenced this issue Oct 28, 2017
@NicBonetto
Refactored falsy warning message and tests. #3
9fc2b7f
NicBonetto added a commit that referenced this issue Oct 28, 2017
@NicBonetto
Changed condition to attribute name. #3
ede38f3
NicBonetto added a commit that referenced this issue Oct 29, 2017
@NicBonetto
Refactored falsy and truthy warning messages with tests updated. #3
ae6fcbf
NicBonetto added a commit that referenced this issue Oct 29, 2017
@NicBonetto
Added missing character. #3
aada64c
NicBonetto added a commit that referenced this issue Oct 29, 2017
@NicBonetto
Fixed warning message. #3
de26d9d
NicBonetto added a commit that referenced this issue Oct 29, 2017
@NicBonetto
Cleared extra whitespace. #3
c7ee43d
NicBonetto added a commit that referenced this issue Oct 29, 2017
@NicBonetto
Refactored warning messages to be clear. #3
2c19ea3
NicBonetto added a commit that referenced this issue Oct 29, 2017
@NicBonetto
Prettified. #3
37207a0
NicBonetto added a commit that referenced this issue Mar 11, 2018
@NicBonetto @gaearon
Fixed invalid prop types error message to be more specific (facebook#…
544d5c7 
…11308)

* Modified tests and corrected error message. #3

* Fixed syntax issues. #3

* Modified test. #3

* Prettified. #3

* Changed warning message to handle true and false boolean values. #3

* Changed test to contain undefined instead of value. #3

* Simplified branch structure. #3

* Refactored branching logic. #3

* Refactored falsy warning message and tests. #3

* Changed condition to attribute name. #3

* Refactored falsy and truthy warning messages with tests updated. #3

* Added missing character. #3

* Fixed warning message. #3

* Cleared extra whitespace. #3

* Refactored warning messages to be clear. #3

* Prettified. #3

* Grammar fix

* Tweak unrelated warning

The message didn't make sense because it appears for *any* attributes, not just numeric ones.

* Tweak the message for more clarity

* Add a special message for false event handlers

* Add missing whitespace

* Revert size changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NicBonetto