Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #12 #13

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Fix issue #12 #13

merged 1 commit into from
Nov 23, 2021

Conversation

yrnehli
Copy link
Contributor

@yrnehli yrnehli commented Nov 22, 2021

No description provided.

@NicholasDawson
Copy link
Owner

Henry, really appreciate your contribution.

I am going to review this fix today and make sure it correctly solves the problem, because there may be something deeper as to why the album API call returns nothing, but maybe this is a slight change in their API.

Did you do any testing on this? If you have, I would love you to share your findings.

I am going to work on making some testing and debug logging tools today to make it easier for people to fix issues.

-Nick

Copy link
Owner

@NicholasDawson NicholasDawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks, good. I investigated a few different scenarios with a user with no albums and a user with empty albums and I couldn't even get a key error even without your fix.

So it is still a mystery as to why this bug occurs, but this will fix the issue for sure.

@NicholasDawson NicholasDawson merged commit 4917e6b into NicholasDawson:master Nov 23, 2021
NicholasDawson added a commit that referenced this pull request Jul 1, 2022
NicholasDawson added a commit that referenced this pull request Jul 16, 2022
Fix issue #12

Former-commit-id: 4917e6b
Former-commit-id: d70abe4
NicholasDawson added a commit that referenced this pull request Jul 16, 2022
Fix issue #12

Former-commit-id: 4917e6b
Former-commit-id: 578c82ace78559c4b78d7b51c659e1ddc6f1023d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants