Added support for requireInteraction and updated tests #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nickersoft
changed the title
Nickersoft
force-pushed
the
require-interaction-plus-tests
branch
from
9b2e07e
to
b0ed063
Compare
|
Wasn't able to write tests for |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push now supports the requireInteraction property for up-to-date browsers. In addition, there are some new tests that check to make sure all attributes are being passed to the Notifications API correctly. That said, requireInteraction is now checked by these new tests, so another test will need to be written for it. Might be a bit longer before this branch is merged.