v3.2.5 [Frontend Module] #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
FBE-008: Include more advanced features for HTMLtoPDF Background: - As the user, i want more to modified or customized PDF that i was convert from HTML or website before. Because current feature are less customizable and just convert it like normal browser Possibility Issue: - Document positioning or layout can be mess if webpage are not optimized for single page layout Resolution: - Implement new features and toggle into HTMLtoPDF page for several customization from iLovePDF API Referecences: - https://developer.ilovepdf.com/docs/guides/html-pdf-api FE-010: Fix multiple same API request Background: For some reason, api/v1/logs/limit has call it twice due unproper async logic. This can make BE service treat that user has 2 request in same time and causing rate limiting hit the limit fastest than it should be. Possibility Issue: - Rate limiting from BE can be hit in a time if user do refresh the page accidentally Resolution: - Wrap async function after button click to avoid async logic run twice before and after button click Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
Nicklas373
added
bug
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changelog: