Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoothed out Bezier Curve Visuals in Wave Box #139

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

OggyP
Copy link
Contributor

@OggyP OggyP commented Jan 3, 2024

The current code in the wave box visualisation mode causes the gradient of the wave to be horizontal at each known point, this technique attempts to smooth out the wave by making the gradient at each point the gradient between its two neighbouring points.

Before:
before-3

After:
after-3

Copy link
Member

@nlogozzo nlogozzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just some styling changes requested. Sorry to be a pain 😆

NickvisionCavalier.Shared/Models/Renderer.cs Outdated Show resolved Hide resolved
NickvisionCavalier.Shared/Models/Renderer.cs Outdated Show resolved Hide resolved
NickvisionCavalier.Shared/Models/Renderer.cs Outdated Show resolved Hide resolved
NickvisionCavalier.Shared/Models/Renderer.cs Outdated Show resolved Hide resolved
NickvisionCavalier.Shared/Models/Renderer.cs Outdated Show resolved Hide resolved
NickvisionCavalier.Shared/Models/Renderer.cs Outdated Show resolved Hide resolved
NickvisionCavalier.Shared/Models/Renderer.cs Outdated Show resolved Hide resolved
NickvisionCavalier.Shared/Models/Renderer.cs Outdated Show resolved Hide resolved
NickvisionCavalier.Shared/Models/Renderer.cs Outdated Show resolved Hide resolved
NickvisionCavalier.Shared/Models/Renderer.cs Show resolved Hide resolved
@OggyP
Copy link
Contributor Author

OggyP commented Jan 3, 2024

No problem! Hopefully I haven't missed anything now. 😀

Copy link
Member

@nlogozzo nlogozzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty-much perfect, just some more C# magic I suggested :)

Let me know if you have any syntax questions, I know it's weird coming from C/C++ sometimes haha

NickvisionCavalier.Shared/Models/Renderer.cs Outdated Show resolved Hide resolved
@nlogozzo nlogozzo self-requested a review January 4, 2024 17:25
@nlogozzo nlogozzo merged commit 45ec4ad into NickvisionApps:main Jan 4, 2024
@nlogozzo
Copy link
Member

nlogozzo commented Jan 4, 2024

Thanks for this :) Going to release a stable version with it now!

@nlogozzo
Copy link
Member

nlogozzo commented Jan 4, 2024

https://github.com/NickvisionApps/Cavalier/releases/tag/2024.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants