Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to have a space between the symbol and amount #644

Closed
julianfairfax opened this issue Aug 17, 2023 · 17 comments · Fixed by #663
Closed

Option to have a space between the symbol and amount #644

julianfairfax opened this issue Aug 17, 2023 · 17 comments · Fixed by #663
Assignees
@nlogozzo
Labels
feature New feature or request in-beta This issue is fixed in a beta version
Milestone
V2023.8.1

Comments

@julianfairfax
Copy link

When using a 3 character currency "symbols" (just letters), Denaro doesn't put a space in-between this symbol and the amount. So, for example, you would see USD1 rather than the correct USD 1. For this reason, Denaro should allow 4 characters as a symbol, or add an option to have a space between the symbol and amount.
@nlogozzo nlogozzo added the feature New feature or request label Aug 17, 2023
@nlogozzo
Copy link
Member

add an option to have a space between the symbol and amount.

I think we'll go with this instead.

@nlogozzo nlogozzo added this to the V2023.8.1 milestone Aug 18, 2023
@nlogozzo nlogozzo changed the title Allow 4 character currency symbols Option to have a space between the symbol and amount Aug 18, 2023
@fsobolev
Copy link
Member

fsobolev commented Aug 18, 2023 •
edited

@nlogozzo The problem is different cultures specify different formats for displaying amount with currency symbol (see CurrencyPositivePattern CurrencyNegativePattern), and I think enforcing $ n pattern is not preferred for all use-cases. Currently Denaro should use patterns from system locale, I think this is the most expected. So if Denaro shows USD1 then it's correct. The reason why we allow 3 characters for symbol is because there are actually currency symbols in real world that require that. Misusing the feature to set currency code as currency symbol should not magically affect patterns in my opinion.
And allowing to set other pattern... Well, look at all possible negative patterns 😄

@nlogozzo
Copy link
Member

I was just thinking of adding a switch to custom currency "show space between symbol and amount", but I think it's best to just look at CurrencyPositivePattern and follow that...prevents modification to database table too

@nlogozzo
Copy link
Member

On further discussion, we will implement a way to change this in custom currency

@JoseBritto
Copy link
Member

On further discussion, we will implement a way to change this in custom currency

So something like this?

image

@nlogozzo
Copy link
Member

Kind of...we were thinking of just having Amount Format Style which is basically a combination of positive and negative and use it for both

@nlogozzo
Copy link
Member

@JoseBritto would you like to take a shot at implementing it?

@JoseBritto
Copy link
Member

I was gonna ask you, but this being due for the next release, I think I'm gonna pass. Maybe can I have a shot at implementing the currency conversion tool? I assume that gonna need to integrate with some api as well.

@nlogozzo
Copy link
Member

but this being due for the next release, I think I'm gonna pass

Ok no worries :) Yeah i'm going to get it done now, so I can release an RC1 tonight and stable for Friday.

Maybe can I have a shot at implementing the currency conversion tool? I assume that gonna need to integrate with some api as well.

Yes feel free to tackle it! I'd like to get it into a release next month but being a big feature I'm ok with it taking some time. And yes it will need some API to pull conversion data from...I don't have any specific one in mind so feel free to choose what you think it best.

If you have any questions, you know how to reach me :)

@JoseBritto
Copy link
Member

Ok thanks :)

@nlogozzo nlogozzo mentioned this issue Aug 23, 2023
Merged
@nlogozzo nlogozzo self-assigned this Aug 23, 2023
@nlogozzo nlogozzo added the in-beta This issue is fixed in a beta version label Aug 24, 2023
@nlogozzo
Copy link
Member

https://github.com/NickvisionApps/Denaro/releases/tag/2023.8.1-rc1

should be on flathub beta soon...whenever gnome gitlab is up again

@julianfairfax
Copy link
Author

https://github.com/NickvisionApps/Denaro/releases/tag/2023.8.1-rc1

should be on flathub beta soon...whenever gnome gitlab is up again

I got the new update from Flathub. When trying to actually use the new setting, Denaro irrecoverably freezes.

@nlogozzo
Copy link
Member

https://github.com/NickvisionApps/Denaro/releases/tag/2023.8.1-rc1

should be on flathub beta soon...whenever gnome gitlab is up again

I got the new update from Flathub. When trying to actually use the new setting, Denaro irrecoverably freezes.

Could you run the app via terminal flatpak run org.nickvision.money and set it again and see if any error message occurs

@julianfairfax
Copy link
Author

https://github.com/NickvisionApps/Denaro/releases/tag/2023.8.1-rc1
should be on flathub beta soon...whenever gnome gitlab is up again

I got the new update from Flathub. When trying to actually use the new setting, Denaro irrecoverably freezes.

Could you run the app via terminal flatpak run org.nickvision.money and set it again and see if any error message occurs

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:35.110: gtk_widget_get_parent: assertion 'GTK_IS_WIDGET (widget)' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:35.110: gtk_widget_add_css_class: assertion 'GTK_IS_WIDGET (widget)' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.737: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.737: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.738: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.738: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.738: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.738: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.747: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.747: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.748: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.748: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.748: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.748: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.762: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.762: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.763: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.763: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.763: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.763: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.778: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.778: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.779: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.779: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.779: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.779: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.795: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.795: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.796: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.796: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.797: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.797: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.812: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.812: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.813: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.813: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.813: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.813: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.829: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.829: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.830: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.830: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.830: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.830: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.845: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.845: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.846: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.847: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.847: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.847: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.862: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.862: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.863: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.863: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.863: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.863: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.879: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.879: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.880: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.880: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.880: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.880: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.896: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.896: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.897: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.897: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.897: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.897: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.911: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.911: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.912: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.912: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.913: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.913: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.928: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.928: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.929: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.929: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.929: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.929: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.944: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.944: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.945: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.945: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.945: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.945: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.962: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.962: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.963: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.963: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.963: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:50.963: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:51.446: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:51.446: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:51.446: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:51.446: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:51.446: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:51.446: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:51.697: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:51.697: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:51.698: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:51.698: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:51.698: _gtk_css_corner_value_get_x: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 17:50:51.698: _gtk_css_corner_value_get_y: assertion 'corner->class == &GTK_CSS_VALUE_CORNER' failed

@nlogozzo
Copy link
Member

I mean those gtk-critical messages can be ignored...was the format correctly displayed when you reopened the account? If so, how many transactions do you have in the account?

@julianfairfax
Copy link
Author

I mean those gtk-critical messages can be ignored...was the format correctly displayed when you reopened the account? If so, how many transactions do you have in the account?

This issue occurs even when creating a brand new account. Like, if you select the option to use a custom currency during the account creation process, it's an issue.

nlogozzo added a commit that referenced this issue Aug 27, 2023
@nlogozzo
All - Fix Amount Display Style Crash
f4a705d 
From #644
@nlogozzo
Copy link
Member

nlogozzo commented Aug 27, 2023 •
edited

This issue occurs even when creating a brand new account. Like, if you select the option to use a custom currency during the account creation process, it's an issue.

idk how we didn't see this as I swear it was working no problem in tested...anyway fixed with f4a705d

This was referenced Sep 2, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlogozzo nlogozzo

Labels
feature New feature or request in-beta This issue is fixed in a beta version
Projects
None yet
Milestone
V2023.8.1
Development

Successfully merging a pull request may close this issue.

Amount Display Style Option in Custom Currency NickvisionApps/Denaro
4 participants
@nlogozzo @julianfairfax @JoseBritto @fsobolev