Subtitle Enhancements + Code Cleanup #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When --no-net-check is specified, Parabolic will not use NetworkMonitor to watch for network changes. Useful for running Parabolic vs WSL where netwrok status doesn't work When --no-net-check is specified, a URL to launch CANNOT be specified as this argument is only intended for debugging/testing and not in production
fsobolev
requested changes
Nov 8, 2023
NickvisionTubeConverter.Shared/Controllers/MainWindowController.cs
Outdated
Show resolved
Hide resolved
Merged
DaPigGuy
reviewed
Nov 11, 2023
NickvisionTubeConverter.GNOME/Resources/brain-augemnted-symbolic.svg
Outdated
Show resolved
Hide resolved
fsobolev
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #618
Fixes #629
Fixes #642
Other Changes:
Subtitle Langswill include auto-generated subtitles, unless the new auto-generated subtitles option is offShow Completedbutton on Downloading pageAddDownloadDialog