Skip to content
This repository has been archived by the owner on May 14, 2020. It is now read-only.

Commit

Permalink
GSD and headerbar transparency (#249)
Browse files Browse the repository at this point in the history
* gtk3: Fix headerbar transparency on some apps

Some applications draw additional headerbar elements on top of the
main csd headerbar. This results in the headerbar appearing
non-transparent, even if transparency is enabled, as two (or more)
backgrounds with 0.97 alpha are stacked on top of each other.

Fix this by making the background transparent on every headerbar
that's descendant of another headerbar.

* gtk3: Fix titlebar separators with sidebar

This fixes separators with sidebar class on titlebars.

The issue was present at least on gnome-control-center 3.32, as
reported here: #238
  • Loading branch information
fossfreedom committed May 19, 2019
1 parent 9cadf80 commit 2c45d9e
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
5 changes: 5 additions & 0 deletions common/gtk-3.0/3.18/sass/_common.scss
Original file line number Diff line number Diff line change
Expand Up @@ -1091,6 +1091,11 @@ GtkComboBox {
@extend %header_widgets;
}

.csd headerbar headerbar,
.csd headerbar headerbar:backdrop {
background-color: transparent;
}

%header_separator {
-GtkWidget-wide-separators: true;
-GtkWidget-separator-width: 1px;
Expand Down
15 changes: 15 additions & 0 deletions common/gtk-3.0/3.20/sass/_common.scss
Original file line number Diff line number Diff line change
Expand Up @@ -1115,6 +1115,21 @@ headerbar {
@extend %titlebar;
}

.titlebar separator.sidebar {
background-color: transparent;
border: 0 solid $header_border;
box-shadow: inset 0 1px lighten($header_bg, 3%);
margin: 0;

&:dir(ltr) { border-width: 0 1px 1px 0; }
&:dir(rtl) { border-width: 0 0 1px 1px; }
}

.csd headerbar headerbar,
.csd headerbar headerbar:backdrop {
background-color: transparent;
}

%header_separator {
min-width: 1px;
min-height: 1px;
Expand Down

0 comments on commit 2c45d9e

Please sign in to comment.